test: usability in err msg on linguist clone

This commit is contained in:
Alex Bezzubov
2023-09-22 13:16:20 +02:00
parent 8b8cc8a17b
commit 561ffd9c86

View File

@ -17,13 +17,13 @@ func MaybeCloneLinguist(envVar, url, commit string) (string, bool, error) {
if !isLinguistCloned { if !isLinguistCloned {
linguistTmpDir, err = ioutil.TempDir("", "linguist-") linguistTmpDir, err = ioutil.TempDir("", "linguist-")
if err != nil { if err != nil {
return "", false, err panic(err)
} }
isCleanupNeeded = true isCleanupNeeded = true
cmd := exec.Command("git", "clone", "--depth", "150", url, linguistTmpDir) cmd := exec.Command("git", "clone", "--depth", "150", url, linguistTmpDir)
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
panic(fmt.Errorf("%s: %w", cmd.String(), err)) panicOn(cmd.String(), err)
} }
} }
@ -38,11 +38,15 @@ func MaybeCloneLinguist(envVar, url, commit string) (string, bool, error) {
cmd := exec.Command("git", "checkout", commit) cmd := exec.Command("git", "checkout", commit)
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
panic(fmt.Errorf("%s: %w", cmd.String(), err)) panicOn(cmd.String(), err)
} }
if err = os.Chdir(cwd); err != nil { if err = os.Chdir(cwd); err != nil {
panic(fmt.Errorf("%s: %w", cmd.String(), err)) panicOn(cmd.String(), err)
} }
return linguistTmpDir, isCleanupNeeded, nil return linguistTmpDir, isCleanupNeeded, nil
} }
func panicOn(cmd string, err error) {
panic(fmt.Errorf("%q returned %w", cmd, err))
}